chore: bump copyright to 2023 and fix wrong copyrights#5892
chore: bump copyright to 2023 and fix wrong copyrights#5892PastaPastaPasta merged 2 commits intodashpay:developfrom
Conversation
|
I wonder if you could make this a scripted diff easily? |
2c18f2f to
f653c96
Compare
|
I wonder if it would be better for you backdate this commit f653c96 back to 2023 to that we don't have that issue of "bump copyright to 2024 because we bumped copyright to 2023"? We would likely then have to merge via merge commit |
|
Also it appears the scripted diff fails |
f653c96 to
49b2978
Compare
that is a good idea, it works, thanks. |
4f35b52 to
86a4dc5
Compare
I tried to set mocked date for commit, and it works locally, but CI still complains: https://gitlab.com/dashpay/dash/-/jobs/6232575556 So, I turned a commit to non-scripted one, have no idea why CI behaves differently. |
|
You could try to script it so. add a |
There's already a script that does it by more advanced way using git history: it is just doesn't work fully as expected in CI |
86a4dc5 to
2e81661
Compare
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
that's a result of: contrib/devtools/copyright_header.py update ./ it is not scripted diff, because it works differentlly on my localhost and in CI: CI doesn't want to use git commit date which is mocked to 30th Dec of 2023
2e81661 to
097a8e7
Compare
Issue being fixed or feature implemented
Bump copyright year to 2023-2024
What was done?
run
copyright_header.py reportandcopyright_header.py updateprevious work: https://github.com/dashpay/dash/pull/5160/files
How Has This Been Tested?
Please, notice, that copyrights should be updated at the end of year, not at the beginning of year for next years.
That prevent bumping year for files where is only changes in that year - bumping a copyright. This misbehavior can be validated by running
copyright_header.py updatetwice. So, bump 2024 should be done in December 2024, not in 2025.Breaking Changes
n/a
Checklist: